Skip to content

Infinity in CUDA kernels#359

Merged
abergeron merged 2 commits intoTheano:masterfrom
kohr-h:infinity
Feb 20, 2017
Merged

Infinity in CUDA kernels#359
abergeron merged 2 commits intoTheano:masterfrom
kohr-h:infinity

Conversation

@kohr-h
Copy link
Copy Markdown
Contributor

@kohr-h kohr-h commented Feb 20, 2017

The INFINITY C99 macro seems to be unavailable in CUDA kernels, while OpenCL has it. I added it to the default preamble in the same manner as the NAN macro.

Copy link
Copy Markdown
Member

@nouiz nouiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem good to me, but I'll let @abergeron merge.

@kohr-h
Copy link
Copy Markdown
Contributor Author

kohr-h commented Feb 20, 2017

You may want to run the tests on CUDA and OpenCL. I ran them only on CUDA, but had some other kernel code using INFINITY which ran fine on OpenCL, so it's only an educated guess that the test will succeed there.

@abergeron abergeron merged commit d0b9c2c into Theano:master Feb 20, 2017
@kohr-h kohr-h deleted the infinity branch February 20, 2017 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants